fix: handle null start state in pie leap#299
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime crash in the PieLeap custom animation when the starting arc (from) is null, by normalizing inputs and adding a regression unit test.
Changes:
- Add normalization logic so
PieLeapcan safely handlenull/partialfrom/toprops. - Compute the off-screen starting geometry from normalized values instead of directly reading
from.x/from.y. - Add a unit test covering the
null fromcase.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/vstory-animate/src/customAnimates/pie-leap.ts | Normalize from/to inputs and derive start geometry from normalized props to avoid null dereferences. |
| packages/vstory-animate/tests/unit/index.test.ts | Add regression test ensuring PieLeap doesn’t crash when from is null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xuefei1313
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PieLeapinput so the animation can handle anullstart arcfrom.x/from.ydirectlynull fromcase that reproduced the BugServer failureTesting
npm test -- --runInBandinpackages/vstory-animateContext
This fixes the BugServer
animate/pie-leapruntime error:Cannot read properties of null (reading 'y').